-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odd rendering of table #60
Comments
It identifies |
To elaborate on @muesli’s comment, numbers align right by default, the same way they would in a spreadsheet. This is a great example of why that isn't always ideal! |
Ohhh. I see it. The others are all two-dot semver versions or just plain ol' strings. It's not like it hurts anything, but it just struck me as odd. 😄 |
#87 Hello there, great package here. Is there an ETA for fixing this? I could help if that's something you'd like to see fix soon. I know I would :-) |
I'm afraid I still haven't looked into it, so no ETA at this point. Help is always appreciated though! |
To elaborate a bit more: currently we let the table renderer automatically detect column alignments, which is probably causing this issue. I think we should try to tackle this along with #65 and stick to a fixed alignment as specified in the markdown's table header. |
Sounds great. Yes a fixed alignment would fix that. Later it could be improved with adding support to different alignments but for now, sticking with a consistent alignment, whatever it is, would do the trick. |
* wip Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * wip * wip * wip * fix: autolink closes #290 * fix: escape characters closes #106 closes #274 closes #311 * fix: table * ci: golangci lint update * feat: use x/golden * test: #106 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #290 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #312 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #257 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #149 * fix: #239 * feat: use lipgloss table closes #262 Co-authored-by: bashbunni <bunni@bashbunni.dev> * fix: codespan is not a block * test: #315 * test: #316 * fix: #316 * test: table * fix: codespans, tables * test: table * test: #117 * test: #60 * fix: rm stylewriter * fix: #313 * fix: margin * fix: blocks and word wrap * fix: build Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: gitattributes * fix: test opt Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: stable lipgloss Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: double styles * fix: tables * fix: tables --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: bashbunni <bunni@bashbunni.dev>
* wip Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * wip * wip * wip * fix: autolink closes #290 * fix: escape characters closes #106 closes #274 closes #311 * fix: table * ci: golangci lint update * feat: use x/golden * test: #106 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #290 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #312 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #257 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #149 * fix: #239 * feat: use lipgloss table closes #262 Co-authored-by: bashbunni <bunni@bashbunni.dev> * fix: codespan is not a block * test: #315 * test: #316 * fix: #316 * test: table * fix: codespans, tables * test: table * test: #117 * test: #60 * fix: rm stylewriter * fix: #313 * fix: margin * fix: blocks and word wrap * fix: build Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: gitattributes * fix: test opt Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: stable lipgloss Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: double styles * fix: tables * fix: tables --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: bashbunni <bunni@bashbunni.dev>
All,
First let me say I do love
glow
. Just learned about it recently and it's one less reason I don't need to spawn a browser when editing Markdown (which I'm still learning).However, I noticed that for some reason a table of mine is rendering...oddly. And I don't know why. The file in question is this README.md. When I run it through
glow
, the entries for three of the rows have odd/different justification:I tried looking in vim with
:set list
on, but I don't see any odd characters in those rows. Any ideas on what I might have done?The text was updated successfully, but these errors were encountered: