Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove huh as a dependency #741

Closed
bashbunni opened this issue Dec 4, 2024 · 5 comments · Fixed by #742
Closed

refactor: remove huh as a dependency #741

bashbunni opened this issue Dec 4, 2024 · 5 comments · Fixed by #742
Assignees

Comments

@bashbunni
Copy link
Member

gum choose

  • add header
  • add filter
    combine gum choose and gum filter
  • full screen option
  • select/unselect all

bash to check what bugs have been fixed in prev versions of huh and gum to test against this new branch

@bashbunni bashbunni added bug Something isn't working enhancement New feature or request cmd/choose labels Dec 4, 2024
@bashbunni
Copy link
Member Author

bug fixes in previous gum versions - for reference when doing validation on the changes (I can help with this)

Impacted commands

Use Huh for Gum Choose by @maaslalani in #521
Use Huh for Gum Confirm by @maaslalani in #522
Use Huh for Gum File by @maaslalani in #523
Use Huh for Gum Input by @maaslalani in #524
Use Huh for Gum Write by @maaslalani in #525

Features

Show help with Huh? by @maaslalani in #587

Fixes (gum)

v0.14.1

Handle huh? user aborted error by @MikaelFangel in #578
Cursor styling by @MikaelFangel in #592
Re-introduce ESC for gum write by @MikaelFangel in #579

v0.14.2

drop left padding in choose in #597
fix race conditon where spinner could mis-render in #621
fix a bug where choose could crash when spacebar is pressed twice #587
fix a bug where the foreground color could not be set in choose #614
fix a bug where foreground could not be set in write #583
fix a bug where keypresses could crash choose #580
restore y/n keybindings to confirm #568
restore centering to buttons in confirm #566

v0.14.4

e095a91: fix(input): wrong height when using borders in the header (@caarlos0)
d722a2f: fix: height 0 by default (#640) (@caarlos0)
046a4d3: fix: use 0 as default width (#634) (@caarlos0)
9db5c7f: fix: select all keybindings (#639) (@caarlos0)
96448e0: fix: show background style help (#641) (@caarlos0)

Fixes (huh)

v0.5.0

Resolve conflict between select and filter by @MikaelFangel in charmbracelet/huh#252

v0.5.2

improve distinction in field select by @csandeep in charmbracelet/huh#304

v0.5.3

fix: group varying heights by @bashbunni in charmbracelet/huh#350
fix: group size when height is 0 by @caarlos0 in charmbracelet/huh#363
fix(filepicker): not closing on close by @caarlos0 in charmbracelet/huh#323
fix(select): wrapping selects by @caarlos0 in charmbracelet/huh#324
fix(select): select all/none by @caarlos0 in charmbracelet/huh#325
fix(multiselect): contextual 'select all' help text by @meowgorithm in charmbracelet/huh#342
fix(spinner): light color in title by @hyorigo in charmbracelet/huh#346
fix (multiselect): set filterable not working by @caarlos0 in charmbracelet/huh#335

Also

refactor: use a selector type to select items by @aymanbagabas in charmbracelet/huh#328
refactor: make item selector into a slice container by @aymanbagabas in charmbracelet/huh#334

@MikaelFangel
Copy link
Contributor

@bashbunni - Just to understand this issue correctly. Does it concern only removing huh as a dependency for gum choose or from gum in general? Also is the goal to recreate the behavior from before huh was introduced to gum.

@meowgorithm
Copy link
Member

Hey, @MikaelFangel. We’re planning on removing Huh in Gum across the board, so choose, confirm, write, input, and file.

After the switch we noticed that we lost some really good functionality and behavior, and found that working on Gum was harder because Huh needed to support use cases specific to Gum in addition to its main purpose. The original Bubble Tea applications in Gum are pretty simple and are much easier to maintain.

Anyway, while we’re reverting to pre-Huh code, we’re also on adding some of the features added post-Huh. We’d love to hear is if there’s any functionality that Huh added that you like to see preserved.

@MikaelFangel
Copy link
Contributor

Thank you for explaining it to me. The plan seems solid, and I don't have any specifics about the features I'd like to see preserved. Please let me know if there's anything I can do to help 😄

@meowgorithm
Copy link
Member

@MikaelFangel Awesome, that's great to get your vote of confidence. With regard to help, will do. Thanks for all your contributions so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants