fix: group size when height is 0 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if height is not set, it will never actually work properly. refs charmbracelet/gum#582 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
aymanbagabas
approved these changes
Aug 19, 2024
renovate bot
referenced
this pull request
in jippi/dottie
Aug 23, 2024
….mod (#85) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/huh](https://togithub.com/charmbracelet/huh) | `v0.5.2` -> `v0.5.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/huh (github.com/charmbracelet/huh)</summary> ### [`v0.5.3`](https://togithub.com/charmbracelet/huh/releases/tag/v0.5.3) [Compare Source](https://togithub.com/charmbracelet/huh/compare/v0.5.2...v0.5.3) ### Crushin’ bugs This release fixes a buncha bugs in Huh and [Gum](https://togithub.com/charmbracelet/gum) alike. Gum users, stay tuned for an update later today. #### What's Changed ##### Fixed - fix: group varying heights by [@​bashbunni](https://togithub.com/bashbunni) in [https://github.com/charmbracelet/huh/pull/350](https://togithub.com/charmbracelet/huh/pull/350) - fix: group size when height is 0 by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/363](https://togithub.com/charmbracelet/huh/pull/363) - fix(filepicker): not closing on close by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/323](https://togithub.com/charmbracelet/huh/pull/323) - fix(select): wrapping selects by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/324](https://togithub.com/charmbracelet/huh/pull/324) - fix(select): select all/none by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/325](https://togithub.com/charmbracelet/huh/pull/325) - fix(multiselect): contextual 'select all' help text by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/huh/pull/342](https://togithub.com/charmbracelet/huh/pull/342) - fix(spinner): light color in title by [@​hyorigo](https://togithub.com/hyorigo) in [https://github.com/charmbracelet/huh/pull/346](https://togithub.com/charmbracelet/huh/pull/346) - fix (multiselect): set filterable not working by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/335](https://togithub.com/charmbracelet/huh/pull/335) - fix(lint): golangci-lint issues by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/378](https://togithub.com/charmbracelet/huh/pull/378) #### Other Stuff - chore: update codeowners by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/379](https://togithub.com/charmbracelet/huh/pull/379) - refactor: use a selector type to select items by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/charmbracelet/huh/pull/328](https://togithub.com/charmbracelet/huh/pull/328) - refactor: make item selector into a slice container by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/charmbracelet/huh/pull/334](https://togithub.com/charmbracelet/huh/pull/334) #### New Contributors - [@​bashbunni](https://togithub.com/bashbunni) made their first contribution in [https://github.com/charmbracelet/huh/pull/350](https://togithub.com/charmbracelet/huh/pull/350) - [@​hyorigo](https://togithub.com/hyorigo) made their first contribution in [https://github.com/charmbracelet/huh/pull/346](https://togithub.com/charmbracelet/huh/pull/346) **Full Changelog**: charmbracelet/huh@v0.5.2...v0.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */1 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if height is not set, it will never actually work properly.
refs charmbracelet/gum#582