-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix Light Color for Spinner Title Style #346
Conversation
Bug: Title Text is same white on Light background terminal
Thanks for this. Mind posting a screenshot so we can see what it looks like on a light background? |
Btw, the magic color #00020A is the reverse (or complementary) color of a given hex color #FFFDF5. Given hex color: #FFFDF5
So, the reverse color of #FFFDF5 is #00020A. |
@meowgorithm I've added the requested screenshots and code samples demonstrating the issue and fix. Could you please review the updated PR when you have a moment? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @hyorigo!
Now I'm wondering if Lip Gloss should have color manipulation tools.
@meowgorithm yeah seriously, this is really great |
….mod (#85) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/huh](https://togithub.com/charmbracelet/huh) | `v0.5.2` -> `v0.5.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcharmbracelet%2fhuh/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcharmbracelet%2fhuh/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcharmbracelet%2fhuh/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcharmbracelet%2fhuh/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/huh (github.com/charmbracelet/huh)</summary> ### [`v0.5.3`](https://togithub.com/charmbracelet/huh/releases/tag/v0.5.3) [Compare Source](https://togithub.com/charmbracelet/huh/compare/v0.5.2...v0.5.3) ### Crushin’ bugs This release fixes a buncha bugs in Huh and [Gum](https://togithub.com/charmbracelet/gum) alike. Gum users, stay tuned for an update later today. #### What's Changed ##### Fixed - fix: group varying heights by [@​bashbunni](https://togithub.com/bashbunni) in [https://github.com/charmbracelet/huh/pull/350](https://togithub.com/charmbracelet/huh/pull/350) - fix: group size when height is 0 by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/363](https://togithub.com/charmbracelet/huh/pull/363) - fix(filepicker): not closing on close by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/323](https://togithub.com/charmbracelet/huh/pull/323) - fix(select): wrapping selects by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/324](https://togithub.com/charmbracelet/huh/pull/324) - fix(select): select all/none by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/325](https://togithub.com/charmbracelet/huh/pull/325) - fix(multiselect): contextual 'select all' help text by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/huh/pull/342](https://togithub.com/charmbracelet/huh/pull/342) - fix(spinner): light color in title by [@​hyorigo](https://togithub.com/hyorigo) in [https://github.com/charmbracelet/huh/pull/346](https://togithub.com/charmbracelet/huh/pull/346) - fix (multiselect): set filterable not working by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/335](https://togithub.com/charmbracelet/huh/pull/335) - fix(lint): golangci-lint issues by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/378](https://togithub.com/charmbracelet/huh/pull/378) #### Other Stuff - chore: update codeowners by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/379](https://togithub.com/charmbracelet/huh/pull/379) - refactor: use a selector type to select items by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/charmbracelet/huh/pull/328](https://togithub.com/charmbracelet/huh/pull/328) - refactor: make item selector into a slice container by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/charmbracelet/huh/pull/334](https://togithub.com/charmbracelet/huh/pull/334) #### New Contributors - [@​bashbunni](https://togithub.com/bashbunni) made their first contribution in [https://github.com/charmbracelet/huh/pull/350](https://togithub.com/charmbracelet/huh/pull/350) - [@​hyorigo](https://togithub.com/hyorigo) made their first contribution in [https://github.com/charmbracelet/huh/pull/346](https://togithub.com/charmbracelet/huh/pull/346) **Full Changelog**: charmbracelet/huh@v0.5.2...v0.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */1 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bug: Title Text is same white on Light background terminal