Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5329 Animation duration is not consistent across browsers #5331

Merged
merged 4 commits into from
Jan 2, 2019
Merged

#5329 Animation duration is not consistent across browsers #5331

merged 4 commits into from
Jan 2, 2019

Conversation

serhii-yakymuk
Copy link
Contributor

Possible solution for #5329

@serhii-yakymuk
Copy link
Contributor Author

Chart.js/src/core/core.controller.js

Line 525 in 7c3e934

if (animationOptions && ((typeof duration !== 'undefined' && duration !== 0) || (typeof duration === 'undefined' && animationOptions.duration !== 0))) {

I think it should be enough just to check for "falsy" values here:
if (animationOptions && (duration || animationOptions.duration)) {

So code climate won't complain about complexity, am I missing something?

@kurkle
Copy link
Member

kurkle commented Jan 1, 2019

This looks good.
Updated fiddle (with master+this PR): https://jsfiddle.net/8g3g3z3u/8/
2.7.2 (same as master considering animation): https://jsfiddle.net/8g3g3z3u/7/

@simonbrunel simonbrunel added this to the Version 2.8 milestone Jan 2, 2019
@simonbrunel simonbrunel merged commit c51ac8a into chartjs:master Jan 2, 2019
@simonbrunel simonbrunel mentioned this pull request Jan 2, 2019
Closed
@simonbrunel
Copy link
Member

Thanks @serhii-yakymuk

@etimberg etimberg mentioned this pull request Feb 12, 2019
Closed
@emmcb emmcb mentioned this pull request Mar 2, 2019
Closed
simonbrunel pushed a commit that referenced this pull request Mar 4, 2019
@kurkle @simonbrunel
Fix animation regression introduced by #5331 (#6108)
344628b
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@serhii-yakymuk @simonbrunel
Make animation duration consistent across browsers (chartjs#5331)
ea55455
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @simonbrunel
Fix animation regression introduced by chartjs#5331 (chartjs#6108)
1b35fe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@serhii-yakymuk @kurkle @simonbrunel @benmccann @s-yakymuk