Clean up branding #112
Clean up branding #112
Conversation
sleshchenko
force-pushed
the
cleanUpBranding
branch
from
c7a5dc7 to
0e37555
Compare
|
Code coverage diff between base branch:master and head branch: cleanUpBranding
|
|
Code coverage diff between base branch:master and head branch: cleanUpBranding
|
| updateRestApiClient(): void { | ||
| const baseUrl = this.baseUrl; | ||
| const headers = this.token ? { Authorization: `Bearer ${this.token}` } : {}; | ||
| this._restApiClient = WorkspaceClient.getRestApi({ baseUrl, headers }); | ||
| } | ||
|
|
||
| async updateJsonRpcMasterApi(): Promise<void> { | ||
| let jsonRpcApiLocation = this.originLocation.replace('http', 'ws') + this.websocketContext; | ||
| let jsonRpcApiLocation = this.originLocation.replace('http', 'ws') + '/api/websocket'; |
There was a problem hiding this comment.
websocketContext should not be defined on the Dashboard side, it more should be on WorkspaceClient level. @akurinnoy and I think that it's OK to hard-code this value on WorkspaceClient side, in the same way as there is like /api/workspace and all related methods paths.
But due to backward compatibility reasons, it's done quickly in this way. Later it can be really fully moved to Che Workspace Client.
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
|
Code coverage diff between base branch:master and head branch: cleanUpBranding
|
sleshchenko
force-pushed
the
cleanUpBranding
branch
from
34afc20 to
8efdf8d
Compare
|
Code coverage diff between base branch:master and head branch: cleanUpBranding
|
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
…or#112) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
What does this PR do?
It cleans up unused parts from branding.
In addition, it removes a couple of hardcoded values that should be read from branding.
For reference, which values are overridden by CRW and RHChe