Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard-next] show warning banner when websockets are not available #18490

Closed
sleshchenko opened this issue Nov 30, 2020 · 5 comments
Closed
Assignees
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

Is your enhancement related to a problem? Please describe.

That's already done for the existing dashboard.
Dashboard next should show warning banner when websockets are not available since it leads to
incorrect work.

The related issue and PR for Dashboard #17280 eclipse-che/che-dashboard#72

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/dashboard labels Nov 30, 2020
@sleshchenko sleshchenko added this to the 7.25 milestone Dec 10, 2020
@sleshchenko
Copy link
Member Author

@ParvathyRV will provide the design
Spoiler: PF banner should be used here https://www.patternfly.org/v4/components/banner/

@parvathyvr
Copy link

@sleshchenko -below is the mock up screen using the PF4 banner for a global alert scenario.
1-Che - Workspace-Global warning

@sleshchenko
Copy link
Member Author

The described issue is fully solved by referenced PRs (not all are merged): warning banner is shown when Dashboard is loaded but websockets are blocked.

But it makes sense to extend the scope a bit:

Then we'll get the following workflow:

  • WebSocket is established.
  • WebSocket is interrupted.
    • WsClient notifies the dashboard about it.
    • Dashboard displays banner that WebSocket is lost
  • WsClient endless tries to reconnect with dynamic delay: first 10 times every second, then every 30 seconds for example.
  • Once Websocket is reestablished, WSClient notifies Dashboard that everything is fine with Websockets now.
  • Dashboard hides the banner.

@sleshchenko
Copy link
Member Author

Seems every related PR is merged. @JPinkney Can this issue be closed or there is anything left?

@sleshchenko sleshchenko modified the milestones: 7.25, 7.26 Feb 1, 2021
@JPinkney
Copy link
Contributor

JPinkney commented Feb 1, 2021

It can be closed

@JPinkney JPinkney closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants