Update @patternfly/react-core to 4.84.4 so that banner component is available #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPinkney
changed the title
akurinnoy
approved these changes
Jan 14, 2021
JPinkney
force-pushed
the
update-patternfly2
branch
from
028d0b0 to
a4886b0
Compare
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
olexii4
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR updates the version of patternfly so that the banner component is available. This new version of Patternfly seems to mess up the padding on the page-section so I had to use a custom class instead of the default Patternfly noPadding
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22936
What issues does this PR fix or reference?
Pre-req for eclipse-che/che#18490
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
Release Notes
Updated patternfly/react-core to ~4.84.4
Docs PR