Add banner that triggers when websockets arent available #126
Conversation
There was a problem hiding this comment.
I think che-workspace-client version should be updated https://www.npmjs.com/package/@eclipse-che/workspace-client/v/0.0.1-1610629049 and then PR check should success
|
I'm updating the workspace-client now, #127 is still required for tests to pass since the component isn't available in the current version of patternfly/react-core |
JPinkney
force-pushed
the
override-params2
branch
from
6c8e116 to
e9b8e85
Compare
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
| @@ -26,13 +29,18 @@ export class CheWorkspaceClient { | |||
| private websocketContext: string; | |||
| private _restApiClient: IRemoteAPI; | |||
| private _jsonRpcMasterApi: IWorkspaceMasterApi; | |||
| private _failingWebSockets: string[]; | |||
| private webSocketEventEmitter: EventEmitter; | |||
| private webSocketEventName = 'websocketChanged'; | |||
There was a problem hiding this comment.
If I understand code correctly, I wonder if Che Workspace Client should expose available event names, instead of creating constant in each of client. But it does not block the current PR, but just small refactoring suggestion for later.
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney
force-pushed
the
override-params2
branch
from
c83fe53 to
bbff089
Compare
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR adds a new component called WebSocketBannerAlert that is used for showing the banner alert when a WebSocket is failing to connect
Pre-req PRs:
che-incubator/che-dashboard-next#109
#127
eclipse-che/che-workspace-client#50
What issues does this PR fix or reference?
eclipse-che/che#18490
Release Notes
Added WebSocket troubleshooting banner that triggers when WebSockets are not available
Docs PR