This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Fix page loading when websockets are not available #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
sleshchenko
approved these changes
Jan 8, 2021
olexii4
approved these changes
Jan 8, 2021
JPinkney
force-pushed
the
fix-loading-when-websocket-missing
branch
from
156b4f1 to
5e19a95
Compare
JPinkney
changed the title
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
akurinnoy
approved these changes
Jan 11, 2021
JPinkney
force-pushed
the
fix-loading-when-websocket-missing
branch
from
5e19a95 to
f4febe5
Compare
…orrectly when websockets are unavailable Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
akurinnoy
pushed a commit
to akurinnoy/che-dashboard-next
that referenced
this pull request
Jan 15, 2021
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it so that if websockets aren't available the page will still load correctly. Previously, if you had websockets disabled and try to open the dashboard the view will instantly go white and the console will contain an error with
TypeError: availableTypes is undefined. This way makes it so that everything will work correctly in PreloadDataWhich issue does this PR related to?
Pre-req for eclipse-che/che#18490
Signed-off-by: Josh Pinkney joshpinkney@gmail.com