Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @patternfly/react-core to 4.84.4 so that banner component is available #127

Merged
merged 1 commit into from
Jan 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .deps/EXCLUDED/prod.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ This file lists dependencies that do not need CQs or auto-detection does not wor
| `che-dashboard-e2e@1.0.0` | N/A |
| `@eclipse-che/api@7.18.1` | N/A |
| `@eclipse-che/workspace-client@0.0.1-1608729566` | N/A |
| `@patternfly/react-core@4.84.4` | https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22936 |
6 changes: 3 additions & 3 deletions .deps/prod.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
| `@eclipse-che/api@7.18.1` | EPL-2.0 | N/A |
| [`@eclipse-che/workspace-client@0.0.1-1608729566`](https://github.com/eclipse/che-workspace-client) | EPL-2.0 | N/A |
| [`@patternfly/patternfly@4.10.31`](https://github.com/patternfly/patternfly.git) | MIT | [CQ22346](https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22346) |
| [`@patternfly/react-core@4.18.5`](https://github.com/patternfly/patternfly-react.git) | MIT | [CQ22347](https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22347) |
| [`@patternfly/react-core@4.84.4`](https://github.com/patternfly/patternfly-react.git) | MIT | https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22936 |
| [`@patternfly/react-icons@4.3.5`](https://github.com/patternfly/patternfly-react.git) | MIT | clearlydefined |
| `@patternfly/react-styles@4.3.4` | MIT | clearlydefined |
| [`@patternfly/react-table@4.5.7`](https://github.com/patternfly/patternfly-react.git) | MIT | clearlydefined |
Expand Down Expand Up @@ -48,7 +48,7 @@
| [`fast-json-stable-stringify@2.1.0`](git://github.com/epoberezkin/fast-json-stable-stringify.git) | MIT | clearlydefined |
| [`faye-websocket@0.11.3`](git://github.com/faye/faye-websocket-node.git) | Apache-2.0 | clearlydefined |
| `file-selector@0.1.12` | MIT | [CQ22350](https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22350) |
| [`focus-trap@4.0.2`](git+https://github.com/davidtheclark/focus-trap.git) | MIT | clearlydefined |
| [`focus-trap@6.2.2`](git+https://github.com/focus-trap/focus-trap.git) | MIT | clearlydefined |
| [`follow-redirects@1.5.10`](git@github.com:follow-redirects/follow-redirects.git) | MIT | clearlydefined |
| [`function-bind@1.1.1`](git://github.com/Raynos/function-bind.git) | MIT | [CQ16925](https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16925) |
| [`glob-to-regexp@0.3.0`](https://github.com/fitzgen/glob-to-regexp.git) | BSD | [CQ18717](https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18717) |
Expand Down Expand Up @@ -144,7 +144,7 @@
| [`string.prototype.trimright@2.1.2`](git://github.com/es-shims/String.prototype.trimRight.git) | MIT | clearlydefined |
| [`string.prototype.trimstart@1.0.1`](git://github.com/es-shims/String.prototype.trimStart.git) | MIT | clearlydefined |
| [`symbol-observable@1.2.0`](https://github.com/blesh/symbol-observable.git) | MIT | clearlydefined |
| [`tabbable@3.1.2`](git+https://github.com/davidtheclark/tabbable.git) | MIT | clearlydefined |
| [`tabbable@5.1.5`](git+https://github.com/focus-trap/tabbable.git) | MIT | clearlydefined |
| [`tiny-invariant@1.1.0`](https://github.com/alexreardon/tiny-invariant.git) | MIT | clearlydefined |
| [`tiny-warning@1.0.3`](https://github.com/alexreardon/tiny-warning.git) | MIT | clearlydefined |
| [`tippy.js@5.1.2`](git+https://github.com/atomiks/tippyjs.git) | MIT | clearlydefined |
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"dependencies": {
"@eclipse-che/workspace-client": "^0.0.1-1608729566",
"@patternfly/patternfly": "^4.10.31",
"@patternfly/react-core": "^4.18.5",
"@patternfly/react-core": "~4.84.4",
"@patternfly/react-icons": "^4.3.5",
"@patternfly/react-table": "^4.5.7",
"@types/react-helmet": "^6.1.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,19 @@ exports[`Page header tools should correctly render the component 1`] = `
<nav
aria-label="info button"
className="pf-c-app-launcher pf-m-align-right"
data-ouia-component-id={0}
data-ouia-component-type="PF4/Dropdown"
data-ouia-component-type="PF4/ApplicationLauncher"
data-ouia-safe={true}
>
<button
aria-expanded={false}
aria-haspopup={true}
aria-label="info button"
className="pf-c-app-launcher__toggle"
data-ouia-component-id="OUIA-Generated-DropdownToggle-1"
data-ouia-component-type="PF4/DropdownToggle"
data-ouia-safe={true}
disabled={false}
id="pf-toggle-id-0"
id="pf-dropdown-toggle-id-0"
onClick={[Function]}
onKeyDown={[Function]}
type="button"
Expand Down Expand Up @@ -56,16 +58,19 @@ exports[`Page header tools should correctly render the component 1`] = `
</nav>
<div
className="pf-c-dropdown pf-m-align-right"
data-ouia-component-id={1}
data-ouia-component-id="OUIA-Generated-Dropdown-1"
data-ouia-component-type="PF4/Dropdown"
data-ouia-safe={true}
>
<button
aria-expanded={false}
aria-haspopup={true}
className="pf-c-dropdown__toggle pf-m-plain"
data-ouia-component-id="OUIA-Generated-DropdownToggle-2"
data-ouia-component-type="PF4/DropdownToggle"
data-ouia-safe={true}
disabled={false}
id="pf-toggle-id-1"
id="pf-dropdown-toggle-id-1"
onClick={[Function]}
onKeyDown={[Function]}
type="button"
Expand Down Expand Up @@ -94,7 +99,6 @@ exports[`Page header tools should correctly render the component 1`] = `
>
<path
d="M31.3 192h257.3c17.8 0 26.7 21.5 14.1 34.1L174.1 354.8c-7.8 7.8-20.5 7.8-28.3 0L17.2 226.1C4.6 213.5 13.5 192 31.3 192z"
transform=""
/>
</svg>
</span>
Expand Down
9 changes: 4 additions & 5 deletions src/Layout/Header/__tests__/__snapshots__/index.spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ exports[`Page header should correctly render the component 1`] = `
className="pf-c-page__header-brand-toggle"
>
<button
aria-controls="page-sidebar"
aria-disabled={null}
aria-controls={null}
aria-disabled={false}
aria-expanded="true"
aria-label="Global navigation"
className="pf-c-button pf-m-plain"
data-ouia-component-id={null}
data-ouia-component-id="OUIA-Generated-Button-plain-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
id="nav-toggle"
onClick={[Function]}
tabIndex={null}
role={null}
type="button"
>
<svg
Expand All @@ -41,7 +41,6 @@ exports[`Page header should correctly render the component 1`] = `
>
<path
d="M16 132h416c8.837 0 16-7.163 16-16V76c0-8.837-7.163-16-16-16H16C7.163 60 0 67.163 0 76v40c0 8.837 7.163 16 16 16zm0 160h416c8.837 0 16-7.163 16-16v-40c0-8.837-7.163-16-16-16H16c-8.837 0-16 7.163-16 16v40c0 8.837 7.163 16 16 16zm0 160h416c8.837 0 16-7.163 16-16v-40c0-8.837-7.163-16-16-16H16c-8.837 0-16 7.163-16 16v40c0 8.837 7.163 16 16 16z"
transform=""
/>
</svg>
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ exports[`The LogsTools component should render the component correctly 1`] = `
className=""
>
<button
aria-disabled={null}
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id={null}
data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[Function]}
tabIndex={null}
role={null}
type="button"
>
<svg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ exports[`The LogsTab component should render workspace-logs widget with logs ins
className=""
>
<button
aria-disabled={null}
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id={null}
data-ouia-component-id="OUIA-Generated-Button-link-2"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[Function]}
tabIndex={null}
role={null}
type="button"
>
<svg
Expand Down Expand Up @@ -199,15 +199,15 @@ exports[`The LogsTab component should render workspace-logs widget without logs
className=""
>
<button
aria-disabled={null}
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id={null}
data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[Function]}
tabIndex={null}
role={null}
type="button"
>
<svg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ exports[`Progress component should render progress with loading correctly 1`] =
aria-hidden="true"
className="pf-c-progress__description"
id="che-progress-ind-description"
onMouseEnter={null}
>

</div>
Expand Down
2 changes: 2 additions & 0 deletions src/overrides.styl
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@
color var(--pf-global--icon--Color--light) !important
opacity 1 !important

.pf-c-page-section-no-padding
padding 0 !important
Loading