-
Notifications
You must be signed in to change notification settings - Fork 10
Update @patternfly/react-core so that the banner component is available #107
Conversation
d5a2d00
to
9964ac4
Compare
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
9964ac4
to
1abfbd4
Compare
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
@JPinkney Do you have the needed CQ(@patternfly/react-core@4.84.4)? |
I've just created the CQ and added the link to the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
…ncubator#107) * renamed widget cheInfoNotification -> cheSuccessNotification Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * Added cheInfoNotification widget Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * Added ability to copy the login command to clipboard or manually. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * Added configuration field 'cheCliTool' to product.json Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixed pull request action * fixup! fixed pull request action
What does this PR do?
This PR updates the version of patternfly so that the banner component is available. This new version of Patternfly seems to mess up the padding on the page-section so I had to use a custom class instead of the default Patternfly noPadding
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22936
Which issue does this PR related to?
Pre-req for eclipse-che/che#18490
Signed-off-by: Josh Pinkney joshpinkney@gmail.com