Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Update @patternfly/react-core so that the banner component is available #107

Closed
wants to merge 4 commits into from

Conversation

JPinkney
Copy link
Collaborator

@JPinkney JPinkney commented Jan 6, 2021

What does this PR do?

This PR updates the version of patternfly so that the banner component is available. This new version of Patternfly seems to mess up the padding on the page-section so I had to use a custom class instead of the default Patternfly noPadding

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22936

Which issue does this PR related to?

Pre-req for eclipse-che/che#18490

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

@che-bot
Copy link

che-bot commented Jan 6, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@che-bot
Copy link

che-bot commented Jan 6, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@olexii4
Copy link
Collaborator

olexii4 commented Jan 8, 2021

@JPinkney Do you have the needed CQ(@patternfly/react-core@4.84.4)?

@JPinkney
Copy link
Collaborator Author

JPinkney commented Jan 8, 2021

I've just created the CQ and added the link to the description

Copy link
Collaborator

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@che-bot
Copy link

che-bot commented Jan 11, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@che-bot
Copy link

che-bot commented Jan 11, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@che-bot
Copy link

che-bot commented Jan 11, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@JPinkney JPinkney closed this Jan 13, 2021
akurinnoy added a commit to akurinnoy/che-dashboard-next that referenced this pull request Jan 15, 2021
…ncubator#107)

* renamed widget cheInfoNotification -> cheSuccessNotification

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* Added cheInfoNotification widget

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* Added ability to copy the login command to clipboard or manually.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* Added configuration field 'cheCliTool' to product.json

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixed pull request action

* fixup! fixed pull request action
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants