Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the warning message about failing WebSocket connection #72

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Show the warning message about failing WebSocket connection #72

merged 2 commits into from
Aug 28, 2020

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 22, 2020 •
edited by sleshchenko
Loading

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Added implementation to show the warning message about failing WebSocket connection if it happened.

What issues does this PR fix or reference?

Fixes eclipse-che/che#17280, fixes eclipse-che/che#16537

Screenshot from 2020-08-04 14-23-12

@olexii4
Copy link
Contributor Author

olexii4 commented Jul 22, 2020

@l0rd What do you think about this message The maximum number of attempts to reconnect WebSocket has been reached. WebSocket connection is failed?

@sleshchenko sleshchenko mentioned this pull request Jul 23, 2020
Closed
@olexii4
Copy link
Contributor Author

olexii4 commented Aug 4, 2020 •
edited
Loading

depends on eclipse-che/che-docs#1445 (review)

@sleshchenko sleshchenko mentioned this pull request Aug 20, 2020
Closed
sleshchenko
sleshchenko approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing links to documentation

@olexii4
add WebSocket failing warning
b6fab6a 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
fix docs links
8b89e2b 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 merged commit 5ced64b into master Aug 28, 2020
@olexii4 olexii4 deleted the CHE-17280 branch August 28, 2020 08:45
@che-bot che-bot added this to the 7.19 milestone Aug 28, 2020
@sleshchenko sleshchenko mentioned this pull request Nov 30, 2020
Closed
akurinnoy pushed a commit that referenced this pull request Jan 13, 2021
@olexii4
Quick fixes for dashboard-next (#72)
a78744d 
* quick fixes

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd l0rd left review comments

@sleshchenko sleshchenko sleshchenko approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.19
5 participants
@olexii4 @l0rd @sleshchenko @akurinnoy @che-bot