-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide refresh token arg to che workspace client #134
Conversation
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
3be1dff
to
dbf0364
Compare
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
❌ E2E dashboard-next tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR in conjunction with eclipse-che/che-workspace-client#51 makes it so that you can refresh a token when a websocket is reconnecting. That way, the token used when establishing the websocket connection is always valid. It also removes websocket context.
What issues does this PR fix or reference?
Part of eclipse-che/che#18490 (comment)
Release Notes
Fix an issue where tokens aren't refreshed before websockets are reconnected
Docs PR