Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide refresh token arg to che workspace client #134

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

JPinkney
Copy link
Contributor

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What does this PR do?

This PR in conjunction with eclipse-che/che-workspace-client#51 makes it so that you can refresh a token when a websocket is reconnecting. That way, the token used when establishing the websocket connection is always valid. It also removes websocket context.

What issues does this PR fix or reference?

Part of eclipse-che/che#18490 (comment)

Release Notes

Fix an issue where tokens aren't refreshed before websockets are reconnected

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jan 18, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@sleshchenko sleshchenko deleted the branch eclipse-che:master January 22, 2021 13:42
@sleshchenko sleshchenko reopened this Jan 22, 2021
@sleshchenko sleshchenko changed the base branch from main-react to master January 22, 2021 13:43
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@JPinkney JPinkney force-pushed the refresh-arg branch 2 times, most recently from 3be1dff to dbf0364 Compare January 25, 2021 01:34
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@che-bot
Copy link
Contributor

che-bot commented Jan 25, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@JPinkney JPinkney merged commit 60d8db8 into eclipse-che:master Jan 26, 2021
@JPinkney JPinkney deleted the refresh-arg branch January 26, 2021 02:33
@che-bot che-bot added this to the 7.26 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants