Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix catalog yaml argument and first installation timeout issue #980

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

  1. Fix catalog source yaml argument for olm installer.
  2. Fix timeout installation error, when install plan installs longer than 30 sec. It's reproducible with cluster bot on first installation. Second installation is much faster and bug is not reproducible. Fix important for CRW.

What issues does this PR fix or reference?

eclipse-che/che#18105

How to test this PR?

Test fix timeout error:

  1. Request cluster using bot.
  2. Install Che first time:
$ ./bin/run server:start -n che -p openshift -m

This first installation could fail. With this fix it should not.

Test catalogsource yaml argument:

  1. Create file with custom catalog source yaml:
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: eclipse-che-preview-openshift
  namespace: che
spec:
  sourceType: grpc
  image: quay.io/aandriienko/eclipse-che-openshift-opm-catalog:preview
  updateStrategy:
    registryPoll:
      interval: 5m
  1. Install Che on the Openshift cluster:
$ ./bin/run server:start -n che \
-p openshift \
-m \
--catalog-source-yaml "/home/user/projects/chectl/catalogSource.yaml" \
--package-manifest-name "eclipse-che-preview-openshift" \
--olm-channel "nightly" \
--installer olm

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@AndrienkoAleksandr AndrienkoAleksandr changed the title Fix catalog yaml argument fix: Fix catalog yaml argument Nov 8, 2020
@tolusha tolusha mentioned this pull request Nov 9, 2020
46 tasks
@AndrienkoAleksandr
Copy link
Contributor Author

/retest

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

/rebased

@tolusha
Copy link
Collaborator

tolusha commented Nov 9, 2020

@AndrienkoAleksandr
pls ignore helm test

[11:03:04] → Command failed with exit code 1: helm dependencies update --skip-refresh /home/runner/.cache/chectl/templates/kubernetes/helm/che/
    Error: no cached repository for helm-manager-1067d9c6027b8c3f27b49e40521d64be96ea412858d8e45064fa44afd3966ddc found. (try 'helm repo update'): open /home/runner/.cache/helm/repository/helm-manager-1067d9c6027b8c3f27b49e40521d64be96ea412858d8e45064fa44afd3966ddc-index.yaml: no such file or directory

@AndrienkoAleksandr
Copy link
Contributor Author

pls ignore helm test

I launched this test locally - it's works fine... I think something wrong with this test on the ci.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Nov 9, 2020
@AndrienkoAleksandr
Copy link
Contributor Author

Launched minishift e2e tests locally - passed.

@AndrienkoAleksandr AndrienkoAleksandr merged commit 6d21950 into master Nov 9, 2020
@AndrienkoAleksandr AndrienkoAleksandr changed the title fix: Fix catalog yaml argument fix: Fix catalog yaml argument and first installation timeout issue Nov 9, 2020
AndrienkoAleksandr added a commit that referenced this pull request Nov 9, 2020
* Fix catalog source yaml argument.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

* Improve error handling for install plan and timeout issue.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr added a commit that referenced this pull request Nov 9, 2020
* Fix catalog source yaml argument.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

* Improve error handling for install plan and timeout issue.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr added a commit that referenced this pull request Nov 10, 2020
* Fix catalog source yaml argument.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

* Improve error handling for install plan and timeout issue.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha tolusha deleted the fixCatalogYamlArgument branch April 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants