-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes all notarization issues #859
Conversation
e21166e
to
5b92b6f
Compare
Ad-Hoc build for this pr: https://buildkite.com/chef/chef-chef-workstation-master-omnibus-adhoc/builds/182#_ If this goes green and passes notarization we'll merge this branch so we can begin test a package out of current. |
5b92b6f
to
67d875e
Compare
@@ -0,0 +1,36 @@ | |||
# | |||
# Copyright 2012-2014 Chef Software, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to seem really silly, but can we get this to be 2020 not 2012-2014
@@ -1,7 +1,7 @@ | |||
source "https://rubygems.org" | |||
|
|||
gem "omnibus", git: "https://github.com/chef/omnibus.git", branch: "master" | |||
gem "omnibus-software", git: "https://github.com/chef/omnibus-software.git", branch: "master" | |||
gem "omnibus", git: "https://github.com/chef/omnibus.git", branch: "jm/deep_sign" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update these to master before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to merge pointed at these branches to test get a package out and flip to master once the underlying branches merge
omnibus/config/software/gems.rb
Outdated
@@ -47,6 +47,11 @@ | |||
# for train | |||
dependency "google-protobuf" | |||
|
|||
# This is a transative dep but we need to build from source so binaries are built on current sdk. | |||
# Only matters on mac. | |||
# TODO: Contact gem mainter about getting new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# TODO: Contact gem mainter about getting new release. | |
@todo Contact gem mainter about getting new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the omnibus/omnibus-software changes land and point to master.
67d875e
to
f6bf9ac
Compare
This changes makes the neccessary changes to enable the pkg to pass apples notarization requirements. 1. Update omnibus and omnibus-software to versions that support deep signing 2. Drop 'Developer ID Installer:' from signing key. This lets sigining pick up the correct key for what is being signed. 3. Add bin_dirs and lib_dirs to gems and git-custom-bindir software definitions so siging can find their binaries and libraries. 4. Add software definition for rb-fsevent-gem so we build the gem. This resolves an issue where the shipped binary is build on to old an sdk. 5. Patch rb-fsevent-gem build to work in our environment. Set minimum target to current os and discover the sdk version. Signed-off-by: Jon Morrow <jmorrow@chef.io>
f6bf9ac
to
b42413f
Compare
Description
This changes makes the neccessary changes to enable the pkg to pass apples notarization requirements.
Signed-off-by: Jon Morrow jmorrow@chef.io
Related Issue
chef/omnibus#924
chef/omnibus-software#1146
Types of changes
Checklist: