Implement deep signing for macOS Notarization #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jonsmorrow
force-pushed
the
jm/deep_sign
branch
2 times, most recently
from
9ad0c05
to
9598ad8
Compare
tas50
changed the title
10 tasks
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
9598ad8
to
cfbaf67
Compare
This was referenced Jan 15, 2020
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
cfbaf67
to
7af181d
Compare
tyler-ball
reviewed
Jan 15, 2020
lib/omnibus/packagers/pkg.rb
Outdated
| log.debug(log_key) { " Signing: #{binary}" } | ||
| sign_binary(binary, true) | ||
| end | ||
| libraries.merge binaries |
There was a problem hiding this comment.
What is the reason for merging the binaries into the libraries here after already processing the libraries?
There was a problem hiding this comment.
Nothing specific. In one iteration of the code I think i may have been logging/displaying the list of things we signed. I guess I left it as a way for the caller to determine if anything was signed.
* Adds deep signing of libraries and binaries to the pakacking process for the pkg packager. * Enables the hardened runtime for binaries. * Adds --preserve-xattr flag to pkgbuild so signing is preserved through packaging and install.* In order to deep sign we have to know where a software definition will install binaries and libraries. To facilite this lib_dirs and bin_dirs functions have been added to the software definition. These two functions return defaults that match standard omnibus locations, but allow individual software defs to override if they do something different. Bumps major version since signing deep signing is a major change. Signed-off-by: Jon Morrow <jmorrow@chef.io>
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
7af181d
to
cba1d5d
Compare
10 tasks
tyler-ball
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds deep signing of libraries and binaries to the pakacking process for the pkg packager. It aso enables the hardened runtime for binaries. In order to deep sign we have to know where a software definition will install binaries and libraries. To facilite this lib_dirs and bin_dirs functions have been added to the software definition. These two functions return defaults that match standard omnibus locations, but allow individual software defs to override if they do something different.
Bumps major version since signing deep signing is a major change.
Signed-off-by: Jon Morrow jmorrow@chef.io
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan