Cookbook Artifact API #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsdeleo
force-pushed
the
cookbook-artifact-api
branch
from
c9fbbb8
to
10ea5e7
Compare
|
closed by #178 (reopen if that's not accurate) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Cookbook Artifact API, first iteration. In this iteration, the cookbook artifact API is identical to the existing cookbooks API, but cookbooks are stored in a separate location. In subsequent iterations, this will be modified to improve the security and implement the features/behavior differences described here: https://github.com/chef/chef-rfc/blob/master/rfc022-arbitrary-cookbook-identifiers.md
This is branched from #111 because I want to be able to use both of those at once, but I'd like to merge that one first and then rebase this.
Also it will likely need some work to fix up the
FILE_STORE=true bundle exec rake pedantcase, which was completely failing for me locally on master as well as this branch until I made a change (which didn't completely fix the tests).@jkeiser