/cookbook_artifacts support for in-memory and FILE_STORE backends (not ChefFS) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomcamel
force-pushed
the
cd/cookbook_artifacts
branch
from
76641a9
to
5d898a7
Compare
randomcamel
force-pushed
the
cd/cookbook_artifacts
branch
from
5d898a7
to
02517d7
Compare
randomcamel
force-pushed
the
cd/cookbook_artifacts
branch
from
02517d7
to
953ec38
Compare
randomcamel
force-pushed
the
cd/cookbook_artifacts
branch
from
953ec38
to
845299d
Compare
| delete_data(request) | ||
|
|
||
| # go through the recipes and delete stuff in the file store. | ||
| identified_cookbook_data["recipes"].each do |r| |
There was a problem hiding this comment.
I would expect there to be more than recipes here. Shouldn't it go through all segments of the cookbook files?
|
Just the one comment, then 👍 otherwise. Can you create a bug for hoovering unused checksums on DELETE or PUT of a cookbook? i.e. when a cookbook no longer references a checksum, the file can be deleted as long as no other cookbook references it either. |
| cookbook['metadata']['dependencies'] ||= {} | ||
| cookbook['metadata']['attributes'] ||= {} | ||
| cookbook['metadata']['recipes'] ||= {} | ||
| end | ||
| cookbook['json_class'] ||= 'Chef::CookbookVersion' | ||
|
|
||
| # not sure if there is a material reason for these differences. |
There was a problem hiding this comment.
It's because when json_class is present, Chef's default API client code will try to convert the JSON to a custom ruby object. I didn't want that behavior when dealing with cookbook artifact objects.
|
👍 |
randomcamel
force-pushed
the
cd/cookbook_artifacts
branch
from
e89295d
to
b7353c8
Compare
randomcamel
added a commit
that referenced
this pull request
Dec 10, 2015
/cookbook_artifacts endpoints
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.