Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overcoming Ruby linting error #14182

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Overcoming Ruby linting error #14182

merged 2 commits into from
Jan 17, 2024

Conversation

johnmccrae
Copy link
Contributor

Description

Linting is failing in the verify pipeline. This is because of this [bug](# Due to actions/runner#849, we have to use quotes for '3.0').

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: John McCrae <john.mccrae@progress.com>
@johnmccrae johnmccrae requested review from a team as code owners January 17, 2024 14:56
Signed-off-by: John McCrae <john.mccrae@progress.com>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johnmccrae johnmccrae merged commit 81e45c7 into chef-17 Jan 17, 2024
33 of 35 checks passed
@johnmccrae johnmccrae deleted the jfm/chef17-lint branch January 17, 2024 17:17
@johnmccrae johnmccrae restored the jfm/chef17-lint branch January 17, 2024 22:01
@johnmccrae johnmccrae deleted the jfm/chef17-lint branch January 19, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant