Data Collector server URL validation, and disable on host down #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user configured data_collector.server_url in their Chef config as an empty string, we blissfully passed it along to Chef::HTTP which would eventually raise a TypeError when trying to dup the URI's host. This change validates the server_url when setting up the Data Collector and gives helpful error messages to the user. We also count Errno::EHOSTDOWN as an error worthy of disabling the Data Collector reporter for a given run if the user so chooses.
adamleff
force-pushed
the
adamleff/ipo-277-uri-validation
branch
from
195ac87
to
1e70e79
Compare
|
|
||
| def validate_data_collector_server_url! | ||
| raise Chef::Exceptions::ConfigurationError, | ||
| "data_collector.server_url is configured but empty. Please supply a valid URL." if data_collector_server_url.empty? |
There was a problem hiding this comment.
"is configured but empty" sounds a little technical, can we just say "is empty." ?
|
👍 |
|
👍 with nits |
|
@btm got all the nits ; 👍 once they're done |
|
appveyor error appears unrelated, internal discussion agrees we can merge, so merge I shall... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user configured data_collector.server_url in their Chef config
as an empty string, we blissfully passed it along to Chef::HTTP
which would eventually raise a TypeError when trying to dup the
URI's host. This change validates the server_url when setting up
the Data Collector and gives helpful error messages to the user.
We also count Errno::EHOSTDOWN as an error worthy of disabling
the Data Collector reporter for a given run if the user so chooses.