Fix windows_path converging on every run #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleff
approved these changes
Oct 30, 2017
|
Pinging @lamont-granquist since he brought this up in the original issue |
|
appveyor tests are busted in ways that make me suspect this broke unit test mocking and started really messing with the path on windows or something... |
|
I'll look into the specs for this tomorrow. |
tas50
force-pushed
the
path_idempotency
branch
from
a5dc9e3 to
02b2ac7
Compare
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
path_idempotency
branch
from
4656198 to
0007a10
Compare
|
@lamont-granquist I rebased this and it's passing appveyor and ruby 2.4.2 in travis. It's the same old 2.3 failures that are failing. Any objection to merging this one now? |
|
ah yeah this is trivial, i must have just been grouchy about red appveyor... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6526
Signed-off-by: Tim Smith tsmith@chef.io