Modernize windows_path resource #6699
Conversation
|
windows specs are busted because of the (correct) removal of the hardcoded provider. kind of looks like the provider is missing a provides line. |
lib/chef/resource/windows_path.rb
Outdated
| @@ -24,20 +24,12 @@ class Resource | |||
| # | |||
| # @since 13.4 | |||
| class WindowsPath < Chef::Resource | |||
|
|
|||
| resource_name :windows_path | |||
| provides :windows_path, os: "windows" | |||
There was a problem hiding this comment.
should drop the "os: windows" bit here.
There was a problem hiding this comment.
I was planning to nuke those in Chef 14. I'm certain there's people out there coding around the fact that these are no-ops on non-windows platforms. We can nuke them all out then and everyone is happy.
There was a problem hiding this comment.
they're not no-ops, though, they blow up hard.
There was a problem hiding this comment.
and i think right now chefspec testing of windows_path on anything other than windows might be problematic -- sort of a bug we should fix in chefspec, but its easy enough to fix it so that even on linux or whatever we can resolve windows_path to a resource.
There was a problem hiding this comment.
I thought chefspec was one of the big reasons we kept all this stuff the way it was.
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Signed-off-by: Tim Smith tsmith@chef.io