Pin rspec-expectations due to private API change #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change, we are introducing a temporary version pin of the rspec-expectations gem to version v3.12.3 As part of the v3.12.4/v3.13.0 releases, the private API class RSpec::Matchers::ExpectedsForMultipleDiffs was renamed to RSpec::Matchers::MultiMatcherDiff [1]. chefspec does make use of this class in one instance. A future change should be introduced to properly address this class dependency. Possible options include replicating a minimal replacement, or porting the class to equivalent custom matcher with the chefspec codebase. [1]: rspec/rspec-expectations@d0bb212 Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
tpowell-progress
requested changes
Feb 7, 2024
chefspec.gemspec
Outdated
| @@ -27,4 +27,5 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "chef-cli" | |||
| s.add_dependency "fauxhai-chef", ">= 9.3" | |||
| s.add_dependency "rspec", "~> 3.0" | |||
| s.add_dependency "rspec-expectations", "3.12.3" | |||
There was a problem hiding this comment.
Suggested change
| s.add_dependency "rspec-expectations", "3.12.3" | |
| # temporary restriction to a version of rspec-expectations that includes the `RSpec::Matchers::ExpectedsForMultipleDiffs` class (renamed in 3.12.4) | |
| s.add_dependency "rspec-expectations", "<= 3.12.3" |
added 3 commits
February 7, 2024 10:56
Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
- Merge branch 'main' of github.com:joshuariojas/chefspec - Add new commit so DOC Signoff check passes Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
tpowell-progress
approved these changes
Feb 7, 2024
10 tasks
This was referenced Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this change, we are introducing a temporary version pin of the rspec-expectations gem to version v3.12.3.
As part of the v3.12.4/v3.13.0 releases, the private API class RSpec::Matchers::ExpectedsForMultipleDiffs was renamed to RSpec::Matchers::MultiMatcherDiff 1. chefspec does make use of this class in one instance.
A future change should be introduced to properly address this class dependency. Possible options include replicating a minimal replacement, or porting the class to equivalent custom matcher with the chefspec codebase.
Related Issue
Here is an example of a spec failing within a CD/CI pipeline that automatically pulls in the latest version of the chefspec gem. Note, that chefspec did not have a new release, but the permissive version matching against rspec now introduces this runtime error.
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.