Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin rspec-expectations due to private API change #6

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Pin rspec-expectations due to private API change #6

merged 4 commits into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. Pin rspec-expectations due to private API change 

    In this change, we are introducing a temporary version pin
of the rspec-expectations gem to version v3.12.3

As part of the v3.12.4/v3.13.0 releases, the private API class
RSpec::Matchers::ExpectedsForMultipleDiffs was renamed to
RSpec::Matchers::MultiMatcherDiff [1]. chefspec does make use of this
class in one instance.

A future change should be introduced to properly address this
class dependency. Possible options include replicating a minimal
replacement, or porting the class to equivalent custom matcher
with the chefspec codebase.

[1]: rspec/rspec-expectations@d0bb212

Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
    JR054505 authored and JR054505 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6e3265b View commit details
    Browse the repository at this point in the history

  2. Set rspec-expectations 3.12.3 as the upperbound, add comment

    JR054505 authored and JR054505 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4dea18a View commit details
    Browse the repository at this point in the history

  3. Set rspec-expectations 3.12.3 as the upperbound, add comment 

    Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
    JR054505 authored and JR054505 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    aafb5d5 View commit details
    Browse the repository at this point in the history

  4. Set rspec-expectations 3.12.3 as the upperbound, add comment 

    - Merge branch 'main' of github.com:joshuariojas/chefspec
- Add new commit so DOC Signoff check passes

Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
    JR054505 authored and JR054505 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    571413e View commit details
    Browse the repository at this point in the history