Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/helix: new package (23.05) #261

Merged
merged 1 commit into from
Aug 22, 2023
Merged

contrib/helix: new package (23.05) #261

merged 1 commit into from
Aug 22, 2023

Conversation

wezm
Copy link
Contributor

@wezm wezm commented Aug 5, 2023

Helix looks for system runtime files alongside the binary. Runtime files include themes and 'queries' for syntax highlighting but also a bunch of dynamic libraries for treesitter parsers. For this reason I've installed everything into /usr/libexec/helix with /usr/bin/hx as a symlink to /usr/libexec/helix/hx. However, if there's a better option happy to move things around.

There a couple of patches for treesitter parsers that don't build with clang. I opened PR upstream as well.



def do_install(self):
self.cargo.install(wrksrc="helix-term")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If alice's change in #259 is merged this can be tweaked to use cargo_build_path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know this was even possible, i guess this also technically works for the original issue. not sure which is better :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just get this in as is for now

@wezm wezm marked this pull request as draft August 6, 2023 22:36
@wezm
Copy link
Contributor Author

wezm commented Aug 6, 2023

I've converted this to a draft PR. I'm running into crashes (on x86_64) with the binary I built. Sometimes it panics with a Rust index out of bounds error, other times it just segfaults but it does so reliably as soon as I append line below (o) when editing contrib/alacritty/template.py. I can edit the same file in the same version of Helix on Arch.

@nekopsykose
Copy link
Contributor

i use the master branch of helix that i build myself and don't get any crashes. it could be:

  • some difference between this release and master that they fixed later
  • the vendored tree-sitter grammars we both use (which are also older revisions at this release) could be affected by different env cflags between building in cbuild compared to manually in cli

can you reproduce the same failure just running cargo --install helix_term on the repo manually (at the 23.05 version)?

@wezm
Copy link
Contributor Author

wezm commented Aug 7, 2023

Thanks for the suggestions @nekopsykose. I was able to reproduce the issue with a cargo install from the 23.05 tarball but it was fixed when installing from master. Some reading through the commits since 23.05 revealed helix-editor/helix#7227 and when applied as a patch to 23.05 it seems to fix the issue.

@nekopsykose
Copy link
Contributor

nice :D

@wezm wezm marked this pull request as ready for review August 7, 2023 01:20
@wezm
Copy link
Contributor Author

wezm commented Aug 22, 2023

@q66 anything needed from me to get this one over the line?

@q66
Copy link
Member

q66 commented Aug 22, 2023

no, i just didn't get to it, sorry; it generally looks good, so i'll merge it as is

@q66 q66 merged commit eff8edf into chimera-linux:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants