fix UB in diff gutter #7227
Merged
fix UB in diff gutter #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
pascalkuthe
added
the
S-waiting-on-review
the-mikedavis
approved these changes
Jun 4, 2023
archseer
approved these changes
Jun 4, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
This was referenced Aug 9, 2023
12 tasks
lunagl
added a commit
to lunagl/nixpkgs
that referenced
this pull request
Aug 15, 2023
Applies helix-editor/helix#7227 as a patch until the fix is included in the next release.
zowoq
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Aug 15, 2023
Applies helix-editor/helix#7227 as a patch until the fix is included in the next release.
Artturin
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Oct 5, 2023
Applies helix-editor/helix#7227 as a patch until the fix is included in the next release.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes UB in the diff gutters that lead to crashes in rust 1.71.
See rust-lang/rust#112171 (comment)
Note that this is a temporary fix that I will revert once I land the improvements described in the comment land in ropey. That could take a while tough, and we really don't want UB in the meantime.