mailbox logic: modify conflicting values #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Links to coverage and verification reports for this PR (#293) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
|
Links to coverage and verification reports for this PR (#293) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for handling messages passed through mailbox uses one value for more than one action.
mailbox_data[7:0] == 8'h83is supposed to be used for triggering NMI/Timer/Soft interrupts (this approach is used by theirqtest). Other tests (iside_fetch_precise_bus_error) use it for triggering ibus fault.Let's unify these, starting from the
irqtest.This PR fixes the handling of
nmi_assert_intfor the purpose of fixingirqtest for AXI configuration. Further changes to the mailbox logic should be applied separately.