Change behavior of HwModel::step_until_output_contains(). #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korran
force-pushed
the
hw-model-output
branch
from
1283479
to
249b205
Compare
korran
force-pushed
the
hw-model-output
branch
from
249b205
to
974f013
Compare
jhand2
approved these changes
Oct 10, 2023
After this change, step_until_output_contains() will tolerate additional output after the searched-for string, which often happens with the fpga_realtime hardware model. This makes caliptra_rom::test_generate_csr pass on the FPGA.
korran
force-pushed
the
hw-model-output
branch
from
5ad8fc1
to
6171dc6
Compare
jlmahowa-amd
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, step_until_output_contains() will tolerate additional output after the searched-for string, which often happens with the fpga_realtime hardware model.
This makes caliptra_rom::test_generate_csr pass on the FPGA.