Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] CFI check for TRNG source #954

Merged
merged 8 commits into from
Oct 24, 2023
Merged

[fix] CFI check for TRNG source #954

merged 8 commits into from
Oct 24, 2023

Conversation

mhatrevi
Copy link
Collaborator

@mhatrevi mhatrevi commented Oct 12, 2023

@andreslagarcavilla
Copy link
Collaborator

Needs rebase, please.

Also: "The Caliptra ROM is frozen; changes that affect the binary
require approval from the TAC." -- yes approved. This seems noisy at this stage

rom/dev/src/main.rs Outdated Show resolved Hide resolved
@mhatrevi mhatrevi force-pushed the vmhatre/more-cfi branch 5 times, most recently from 6cab855 to 51ed285 Compare October 20, 2023 16:46
rom/dev/src/main.rs Outdated Show resolved Hide resolved
This fix addresses issue# #920 and #921

This fix also hardens the CFI RNG initialization by providing an additional source of entrophy.
rom/dev/src/start.S Outdated Show resolved Hide resolved
korran
korran previously approved these changes Oct 20, 2023
@nickg-ca
Copy link

Does this address #922 ? I only noticed that when looking at the compiled assembly which calls ureg:: read_volatile_slice and compiler_builtins::mem::memcpy::memcpy, either of which could be glitched to trigger a buffer overflow. For what it's worth I'm somewhat less concerned about #922 than the other issues.

@korran
Copy link
Collaborator

korran commented Oct 23, 2023

Does this address #922 ? I only noticed that when looking at the compiled assembly which calls ureg:: read_volatile_slice and compiler_builtins::mem::memcpy::memcpy, either of which could be glitched to trigger a buffer overflow. For what it's worth I'm somewhat less concerned about #922 than the other issues.

I don't think it does. I propose #989 to solve #922.

@mhatrevi mhatrevi enabled auto-merge (squash) October 24, 2023 03:38
@mhatrevi mhatrevi merged commit 076c670 into main Oct 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caliptra v1.0 Items required for v1.0 Release ROM Issue affects ROM security/countermeasure
Projects
None yet
5 participants