-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chisel3 exception handling #361
Comments
To the extent that we can continue executing past errors, so that we can report as many errors as possible without exiting, I agree. But in the unresumable case, the stack trace is helpful, so the top-level exception handler should still print it. |
So once an exception is thrown and it reaches the top level handler, can you actually resume from where the exception was thrown? |
Resolution: place a "top-level" exception handler in (or around) Driver.elaborate, which just prints out the error (with a stack track) along with other non-fatal errors. |
To do this correctly will require significant restructuring of the code in order to avoid reporting the same error multiple times. I'm submitting a PR that demonstrates a simple (naive) solution, but marking it DO NOT MERGE. We should discuss this at a development meeting, but for the moment I'm bumping the milestone. |
This is resolved via Stage/Phase in Chisel 3.3. |
Excluding Chisel version 3.2 through 3.4 where the ScalaDoc included in the public jars is not the unidoc and thus is split between the subprojects. We still host the unidoc for the latest of those major versions.
We should have a top-level exception handler in chisel3. It should report accumulated errors and warnings before exiting.
The text was updated successfully, but these errors were encountered: