Grouping Chisel API #1073
Merged
Grouping Chisel API #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks! |
edwardcwang
reviewed
Apr 19, 2019
|
|
||
|
|
||
| object group { | ||
| def apply[T <: Data](components: Seq[T], newModule: String, newInstance: String, outputSuffix: Option[String] = None, inputSuffix: Option[String] = None)(implicit compileOptions: CompileOptions): Unit = { |
There was a problem hiding this comment.
Scaladoc would be appreciated :)
|
Would it make sense for this to be a scoped API? Though I guess the problem there is that the items in the scope aren't 'visible' outside, depending on if they need to be referred to from outside or if it's more modular and encapsulated. |
|
The scoping probably won't work for most of my use cases. If I were able to cleanly put a scope around the items I wanted grouped I wouldn't need this pass at all. |
|
Is this still in the works? |
jackkoenig
approved these changes
Jun 5, 2020
|
I think it can be backported to 1.2.x? |
azidar
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2020
* Added group chisel API * Removed println * Added scaladoc * Added more tests * Cleaned spacing and removed println Co-authored-by: Chick Markley <chick@qrhino.com> Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu> Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> (cherry picked from commit 161938b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2020
* Added group chisel API * Removed println * Added scaladoc * Added more tests * Cleaned spacing and removed println Co-authored-by: Chick Markley <chick@qrhino.com> Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu> Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> (cherry picked from commit 161938b)
mergify bot
added a commit
that referenced
this pull request
Jun 8, 2020
* Added group chisel API * Removed println * Added scaladoc * Added more tests * Cleaned spacing and removed println Co-authored-by: Chick Markley <chick@qrhino.com> Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu> Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> (cherry picked from commit 161938b) Co-authored-by: Adam Izraelevitz <azidar@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Jun 22, 2020
* Added group chisel API * Removed println * Added scaladoc * Added more tests * Cleaned spacing and removed println Co-authored-by: Chick Markley <chick@qrhino.com> Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu> Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> (cherry picked from commit 161938b) Co-authored-by: Adam Izraelevitz <azidar@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
At the request of @colinschmidt, added a chisel annotation API for triggering the
firrtl.transforms.GroupComponentstransformation.