Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .mergify.yml #1244

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Create .mergify.yml #1244

merged 3 commits into from
Nov 22, 2019

Conversation

azidar
Copy link
Contributor

@azidar azidar commented Nov 22, 2019

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes
Adds mergify to facilitate backporting and merging PRs.

@azidar azidar requested a review from a team as a code owner November 22, 2019 17:39
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Not tested in any way, but this looks like a fine port of the FIRRTL .megify.yml.

- name: label Mergify backport PR
conditions:
- base=3.2.x
- body~=This is an automated backport of pull request \#\d+ done by Mergify.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- body~=This is an automated backport of pull request \#\d+ done by Mergify.io
- body~=This is an automated backport of pull request \#\d+ performed in the hall of the robot king

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

conditions:
- base=master
actions:
dismiss_reviews:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we also have this on firrtl, but what does this rule do? A naive reading would be that it always just dismisses reviews on master but it clearly doesn't do that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it enables mergify to take the last approved review; a stale review isn't considered if there is another approving one. https://doc.mergify.io/examples.html?highlight=dismiss#id11

@azidar azidar merged commit 4a4abfc into master Nov 22, 2019
@albert-magyar albert-magyar deleted the add-mergify-yml branch May 18, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants