-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create .mergify.yml #1244
Create .mergify.yml #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Not tested in any way, but this looks like a fine port of the FIRRTL .megify.yml
.
- name: label Mergify backport PR | ||
conditions: | ||
- base=3.2.x | ||
- body~=This is an automated backport of pull request \#\d+ done by Mergify.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- body~=This is an automated backport of pull request \#\d+ done by Mergify.io | |
- body~=This is an automated backport of pull request \#\d+ performed in the hall of the robot king |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
conditions: | ||
- base=master | ||
actions: | ||
dismiss_reviews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we also have this on firrtl, but what does this rule do? A naive reading would be that it always just dismisses reviews on master but it clearly doesn't do that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it enables mergify to take the last approved review; a stale review isn't considered if there is another approving one. https://doc.mergify.io/examples.html?highlight=dismiss#id11
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Adds mergify to facilitate backporting and merging PRs.