Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asTypeOf for Clock #1258

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Fix asTypeOf for Clock #1258

merged 2 commits into from
Dec 3, 2019

Conversation

jackkoenig
Copy link
Contributor

See the test. Currently, you cannot cast via .asTypeOf to a Clock. You can legally cast from a Bool to a Clock via .asClock, but when you have Aggregates with Clock members, you would like .asTypeOf to work. This isn't common because it's generally unsafe, but it's reasonable to do in testbench code and obviously our casting should be consistent.

Related issue:

Type of change: bug fix

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes
Support Clock in asTypeOf casting

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Nov 30, 2019
@jackkoenig jackkoenig added this to the 3.2.X milestone Nov 30, 2019
@jackkoenig jackkoenig requested a review from a team as a code owner November 30, 2019 01:31
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Dec 2, 2019
@jackkoenig jackkoenig merged commit 8edca94 into master Dec 3, 2019
@jackkoenig jackkoenig deleted the fix-clock-as-type-of branch December 3, 2019 00:06
mergify bot pushed a commit that referenced this pull request Dec 3, 2019
@jackkoenig
Fix asTypeOf for Clock (#1258)
f048a88 
(cherry picked from commit 8edca94)
@mergify mergify bot mentioned this pull request Dec 3, 2019
Merged
@mergify mergify bot added the Backported This PR has been backported label Dec 3, 2019
mergify bot added a commit that referenced this pull request Dec 3, 2019
@mergify
Fix asTypeOf for Clock (#1258) (#1265)
43de442 
(cherry picked from commit 8edca94)
jackkoenig added a commit that referenced this pull request Feb 28, 2023
@jackkoenig
Merge pull request #1258 from freechipsproject/remove-old-logger
c063ad4 
Remove scala-logging fully in favor of our own logger
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@ucbjrl
Make the member 'logger' added by the trait LazyLogging protected. (#…
3a2a20d 
…1271)

The switch to using our own Logger triggered a latent bug, described in comments to #1258. Make the `val logger` introduced by the 'trait LazyLogging` protected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @aswaterman