Fixed problem creating Interval literals with full ranges #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- boundary testing was not taking binary point into account correctly - add tests to show where things work and where they are supposed to fail
|
Since this is a bugfix, should it be backported to 3.2.x? |
|
If it needs (or is based on) intervals, it shouldn't be backported. Otherwise, I'd say yes, but let's get @chick's input. |
|
Oh right, intervals are not in 3.2, nevermind! |
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
This makes a change to the Dependency API that breaks chisel3. This needs to [skip chisel tests], but is fixed with #1270. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: bug fix
Impact: no functional change
Development Phase: implementation
Release Notes
A bug that affected could cause exceptions when creating intervals with range specifiers was fixed, e.g.
val iLit = 6.0.I(range"[0,6]")would fail even though 6 is legal in that range.