No more compile internal #1384
Merged
No more compile internal #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
force-pushed
the
no-more-compile-internal
branch
from
8375f6b to
e6b1ade
Compare
seldridge
previously approved these changes
Mar 23, 2020
seldridge
dismissed
their stale review
This is gated on @ucbjrl approval and not me!
ucbjrl
approved these changes
Mar 26, 2020
@ucbjrl I take it you mean changing the names from like |
|
Yes. |
This has the effect of causing the coreMacros and chiselFrontend projects to be published separately
* Rename coreMacros to macros * Rename chiselFrontend to core Also make each subproject publish with "chisel3-" as a prefix
jackkoenig
force-pushed
the
no-more-compile-internal
branch
from
e6b1ade to
fbf5e6f
Compare
Merged
edwardcwang
pushed a commit
that referenced
this pull request
Apr 4, 2020
Fix bug introduced in #1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're close to
3.3.0, seems like a good time to do this.Eliminate SBT compile internal stuff. This causes problems for users upstream (see scalacenter/bloop#1138) and since the entire purpose is a bit boutique and counter to standard Scala practice, we might as well eliminate it.
Since the subprojects
coreMacrosandchiselFrontendwill be published separately with this change, I also renamed them to more standard names:coreMacros->macros, published aschisel3-macroschiselFrontend->core, published aschisel3-coreRelated issue:
Type of change: other enhancement
Impact: API modification
Kind of an API modification, it changes the way the project is structured and published. It's possible users are doing source dependencies and reaching in to the subprojects, but this would be unwise and
3.3.0is a reasonable time to change it.Development Phase: implementation
Release Notes
Publish chisel3 as subprojects:
chisel3-macros,chisel3-core, andchisel3