Use thread local storage for ChiselContext. #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducky64
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
This looks sane for now, but the implementation can cause pitfalls in the future if we want to pursue multithreading for performance (since context data from the parent context is discarded). But since that's not a goal for now (or perhaps even in the near future), this is fine, and if it works, should address the parallel tests use case.
ucbjrl
added
Backport
ucbjrl
added
Backport
ucbjrl
added a commit
that referenced
this pull request
Apr 9, 2020
(cherry picked from commit e55c00f)
ucbjrl
added a commit
that referenced
this pull request
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to come up with a self-contained test for this, but was unable to.
I tested it by using this to build/run the bundleStackCrash branch of chisel-template.
Related issue: #1334
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
Use thread local storage for ChiselContext.