Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mergify Backport labeling for 3.2.x #1489

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

jackkoenig
Copy link
Contributor

Brings it inline with the config used in FIRRTL

Related issue:

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

@jackkoenig jackkoenig requested a review from a team as a code owner June 22, 2020 19:24
Copy link
Contributor

@albert-magyar albert-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make it 3.2.x?

@albert-magyar
Copy link
Contributor

I.e., why not make two separate rules (one with 3.2.x as base, one with 3.3.x)

@jackkoenig
Copy link
Contributor Author

Because if we add 3.4.x this applies to everything

@jackkoenig
Copy link
Contributor Author

I think matching the body of This is an automated backport of pull request \#\d+ done by Mergify is sufficient to tell if something is a backport 🙂

@albert-magyar albert-magyar merged commit d099d01 into master Jun 22, 2020
@albert-magyar albert-magyar deleted the fix-backport-labeling branch June 22, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants