Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix treadle dependency for mill #1504

Merged
merged 2 commits into from
Jul 5, 2020
Merged

fix treadle dependency for mill #1504

merged 2 commits into from
Jul 5, 2020

Conversation

sequencer
Copy link
Member

Related issue:

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes
Fix Bug introduced by #1483, which add tredale to chisel dependency.

@sequencer sequencer requested a review from a team as a code owner July 2, 2020 16:12
@sequencer
Copy link
Member Author

@chick request for review.

@sequencer sequencer mentioned this pull request Jul 2, 2020
Merged
chick
chick reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with mill.
I could get things to compile with mill chisel3[2.12.11].compile _
But I could not figure out how to run tests from the command line or the repl.
Can you give me an example of running a test

@sequencer
Copy link
Member Author

sorry my bad, I missed the dependency of chisel3.test, it should work now.

@sequencer
Copy link
Member Author

run with mill chisel3[2.12.11].run,
test with mill chisel3[2.12.11].test

chick
chick approved these changes Jul 5, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works for me.

@chick chick merged commit ac3ad98 into chipsalliance:master Jul 5, 2020
@sequencer sequencer deleted the mill_fix branch July 6, 2020 01:49
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@albertchen-sifive @mergify
EliminateTargetPaths: don't duplicate modules with only one instance (#…
eb52a5c 
…1504)

* EliminateTargetPaths: add lone instance test cases

* EliminateTargetPaths: don't rename lone instances

* get rid of trailing comma

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sequencer @chick