Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax plugin scalac phase order #1568

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

jackkoenig
Copy link
Contributor

It must run after the typer, but doesn't need to "run right after". The
stricter dependency conflicted with the semanticdb-typer.

h/t Øyvind for finding this bug https://groups.google.com/g/chisel-users/c/K_vuliudgLg/m/IYx-QPd4AQAJ

I locally verified that I could reproduce the bug and this fixes it. Unfortunately this is a pretty hard thing to test for (in this repo at least)

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No change

Backend Code Generation Impact

No change

Desired Merge Strategy

  • Squash

Release Notes

Relax plugin scalac phase order. This makes the plugin work with tools like Scala Metals.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

It must run after the typer, but doesn't need to "run right after". The
stricter dependency conflicted with the semanticdb-typer.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Aug 25, 2020
@jackkoenig jackkoenig added this to the 3.4.0 milestone Aug 25, 2020
@jackkoenig jackkoenig requested a review from azidar August 25, 2020 19:35
@jackkoenig jackkoenig requested a review from a team as a code owner August 25, 2020 19:35
@jackkoenig jackkoenig merged commit ca80db2 into master Aug 25, 2020
@jackkoenig jackkoenig deleted the relax-plugin-scalac-phase-order branch August 25, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants