Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It must run after the typer, but doesn't need to "run right after". The
stricter dependency conflicted with the semanticdb-typer.
h/t Øyvind for finding this bug https://groups.google.com/g/chisel-users/c/K_vuliudgLg/m/IYx-QPd4AQAJ
I locally verified that I could reproduce the bug and this fixes it. Unfortunately this is a pretty hard thing to test for (in this repo at least)
Contributor Checklist
docs/src
?Type of Improvement
API Impact
No change
Backend Code Generation Impact
No change
Desired Merge Strategy
Release Notes
Relax plugin scalac phase order. This makes the plugin work with tools like Scala Metals.
Reviewer Checklist (only modified by reviewer)
Please Merge
?