Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -e option work with ChiselStage methods #1630

Merged
merged 3 commits into from
Oct 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/main/scala/chisel3/stage/ChiselStage.scala
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import firrtl.{
ir => fir,
AnnotationSeq,
EmittedFirrtlCircuitAnnotation,
EmittedFirrtlModuleAnnotation,
EmittedVerilogCircuitAnnotation,
EmittedVerilogModuleAnnotation,
HighFirrtlEmitter,
VerilogEmitter,
SystemVerilogEmitter
Expand Down Expand Up @@ -93,11 +95,11 @@ class ChiselStage extends Stage {
annotations: AnnotationSeq = Seq.empty): String = {

execute(Array("-X", "high") ++ args, ChiselGeneratorAnnotation(() => gen) +: annotations)
.collectFirst {
.collect {
case EmittedFirrtlCircuitAnnotation(a) => a
}
.get
.value
case EmittedFirrtlModuleAnnotation(a) => a
}.map(_.value)
.mkString("")

}

Expand All @@ -115,9 +117,10 @@ class ChiselStage extends Stage {
execute(Array("-X", "verilog") ++ args, ChiselGeneratorAnnotation(() => gen) +: annotations)
.collectFirst {
case EmittedVerilogCircuitAnnotation(a) => a
}
.get
.value
case EmittedVerilogModuleAnnotation(a) => a
}.map(_.value)
.mkString("")

}

/** Convert a Chisel module to SystemVerilog
Expand All @@ -134,9 +137,10 @@ class ChiselStage extends Stage {
execute(Array("-X", "sverilog") ++ args, ChiselGeneratorAnnotation(() => gen) +: annotations)
.collectFirst {
case EmittedVerilogCircuitAnnotation(a) => a
}
.get
.value
case EmittedVerilogModuleAnnotation(a) => a
}.map(_.value)
.mkString("")

}
}

Expand Down
27 changes: 24 additions & 3 deletions src/test/scala/chiselTests/stage/ChiselStageSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package chiselTests.stage

import chisel3._
import chisel3.stage.ChiselStage
import chisel3.testers.TesterDriver.createTestDirectory

import chiselTests.Utils

Expand All @@ -14,11 +15,19 @@ import firrtl.options.Dependency

object ChiselStageSpec {

class Bar extends MultiIOModule {
val in = IO(Input(UInt(4.W)))
val out = IO(Output(UInt(4.W)))
out := ~in
}

class Foo extends MultiIOModule {
val addr = IO(Input(UInt(4.W)))
val out = IO(Output(Bool()))
val bar = SyncReadMem(8, Bool())
out := bar(addr)
val memory = SyncReadMem(8, Bool())
val bar = Module(new Bar)
bar.in := addr
out := memory(bar.out)
}

}
Expand All @@ -40,7 +49,13 @@ class ChiselStageSpec extends AnyFlatSpec with Matchers with Utils {
behavior of "ChiselStage.emitFirrtl"

it should "return a High FIRRTL string" in {
ChiselStage.emitFirrtl(new Foo) should include ("mem bar")
ChiselStage.emitFirrtl(new Foo) should include ("mem memory")
}

it should "return a flattened FIRRTL string with '-e high'" in {
val args = Array("-e", "high", "-td", createTestDirectory(this.getClass.getSimpleName).toString)
(new ChiselStage)
.emitFirrtl(new Foo, args) should include ("module Bar")
}

behavior of "ChiselStage.emitVerilog"
Expand All @@ -49,6 +64,12 @@ class ChiselStageSpec extends AnyFlatSpec with Matchers with Utils {
ChiselStage.emitVerilog(new Foo) should include ("endmodule")
}

it should "return a flattened Verilog string with '-e verilog'" in {
val args = Array("-e", "verilog", "-td", createTestDirectory(this.getClass.getSimpleName).toString)
(new ChiselStage)
.emitVerilog(new Foo, args) should include ("module Bar")
}

behavior of "ChiselStage$.elaborate"

it should "generate a Chisel circuit from a Chisel module" in {
Expand Down