Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BitSet implementation with unittest and doc #2223

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

OceanS2000
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation
  • code refactoring

API Impact

This PR adds several operations for manipulation of more generic bit pattern (BitSetFamily) and generate a matching decoder from such a (probably complex) pattern with decoder API.

The API should be backward compatible with existing code using BitPat

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer merged commit 6bd2b0c into chipsalliance:bitset Oct 29, 2021
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
* add os-lib to dependency.

* use os-lib in Z3ModelChecker

* fix for review by Kevin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants