Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update master for 3.5.0 release #2338

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Update master for 3.5.0 release #2338

merged 1 commit into from
Jan 12, 2022

Conversation

jackkoenig
Copy link
Contributor

  • Enable CI for 3.5.x branch
  • Enable Mergify for 3.5.x branch
  • Drop 3.5.x from Mergify

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig
Update master for 3.5.0 release
b9d57bf 
* Enable CI for 3.5.x branch
* Enable Mergify for 3.5.x branch
* Drop 3.5.x from Mergify
@jackkoenig jackkoenig enabled auto-merge (squash) January 12, 2022 05:32
chick
chick approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackkoenig jackkoenig merged commit 6548921 into master Jan 12, 2022
@jackkoenig jackkoenig deleted the update-master-for-3.5 branch January 12, 2022 16:14
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@ekiwi
[smt] treat stop with non-zero ret like an assertion (#2338)
de56a19 
We treat it as an assertion that the stop will
never be enabled. stop(0) will still be ignored
(but now demoted to a info from a warning).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @chick