Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tuple2 Lookupable #2372

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Make Tuple2 Lookupable #2372

merged 7 commits into from
Feb 10, 2022

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Jan 28, 2022

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Adds Tuple2 as something which is Lookupable (can be marked @public).

Backend Code Generation Impact

It doesnt change any verilog.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Make Tuple2 Lookupable

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@mwachs5
Copy link
Contributor Author

mwachs5 commented Jan 28, 2022

I made this a draft to discuss how to extend past a tuple 2... is it really just a copy paste for each one up to tupleN?

@mwachs5
Copy link
Contributor Author

mwachs5 commented Jan 29, 2022

This is failing scalafmtCheck, but when I run sbt scalafmt on my own machine there is no diff. Any suggestions?

@debs-sifive
Copy link
Contributor

@mwachs5 make sure you're using the same scala version as CI when calling scalafmt. I ran into this issue and fixed it by using

sbt ++2.12.15 scalafmtAll

@mwachs5 mwachs5 marked this pull request as ready for review February 9, 2022 23:31
@mwachs5 mwachs5 changed the title Make Tuples Lookupable Make Tuple2 Lookupable Feb 9, 2022
@jackkoenig
Copy link
Contributor

sbt ++2.12.15 scalafmtAll

For the record, I don't think the scala version matters but it's very import to run scalafmtAll instead of just scalafmt. The former includes files in src/test/scala.

@jackkoenig
Copy link
Contributor

Do you want to merge this as is or would you like to add some more Tuples?

@jackkoenig jackkoenig added this to the 3.5.x milestone Feb 9, 2022
@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 10, 2022

Do you want to merge this as is or would you like to add some more Tuples?

I think I would want to merge this as is because it allows Maps to be implemented...

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Feb 10, 2022
@jackkoenig jackkoenig enabled auto-merge (squash) February 10, 2022 00:04
@jackkoenig jackkoenig merged commit 024847d into master Feb 10, 2022
@jackkoenig jackkoenig deleted the lookupable-tuples branch February 10, 2022 00:59
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
(cherry picked from commit 024847d)
@mergify mergify bot added the Backported This PR has been backported label Feb 10, 2022
mergify bot added a commit that referenced this pull request Feb 10, 2022
(cherry picked from commit 024847d)

Co-authored-by: Megan Wachs <megan@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants