-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Tuple2 Lookupable #2372
Make Tuple2 Lookupable #2372
Conversation
I made this a draft to discuss how to extend past a tuple 2... is it really just a copy paste for each one up to tupleN? |
src/test/scala/chiselTests/experimental/hierarchy/InstanceSpec.scala
Outdated
Show resolved
Hide resolved
This is failing scalafmtCheck, but when I run |
@mwachs5 make sure you're using the same scala version as CI when calling scalafmt. I ran into this issue and fixed it by using
|
For the record, I don't think the scala version matters but it's very import to run scalafmtAll instead of just scalafmt. The former includes files in |
Do you want to merge this as is or would you like to add some more Tuples? |
I think I would want to merge this as is because it allows Maps to be implemented... |
(cherry picked from commit 024847d)
Contributor Checklist
docs/src
?Type of Improvement
API Impact
Adds Tuple2 as something which is Lookupable (can be marked @public).
Backend Code Generation Impact
It doesnt change any verilog.
Desired Merge Strategy
Release Notes
Make Tuple2 Lookupable
Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Please Merge
?