Emit FIRRTL bulkconnects whenever possible #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jackkoenig
requested changes
Feb 11, 2022
jared-barocsi
force-pushed
the
bulkconnects
branch
from
e6980a8
to
a4418a1
Compare
jackkoenig
approved these changes
Mar 9, 2022
|
I meant to mark this for backporting but forgot. |
|
@Mergifyio backport 3.5.x |
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Chisel <> semantics differ somewhat from FIRRTL <= semantics, so we only emit <= when it would be legal. Otherwise we continue the old behavior of emitting a connection for every leaf-level Element. Co-authored-by: Deborah Soung <debs@sifive.com> Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 3553a15)
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Mar 10, 2022
Chisel <> semantics differ somewhat from FIRRTL <= semantics, so we only emit <= when it would be legal. Otherwise we continue the old behavior of emitting a connection for every leaf-level Element. Co-authored-by: Deborah Soung <debs@sifive.com> Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 3553a15) Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com> Co-authored-by: Jack Koenig <koenig@sifive.com>
14 tasks
jackkoenig
added a commit
that referenced
this pull request
Feb 28, 2023
Reset, AsyncReset, Interval, attach, assert, assume, and cover have all been added as keywords but not added to the allowlist for parsing as ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to emit a FIRRTL bulkconnect when connecting
Aggregates either mono- or bi-directionally. This does not cover all possible cases (e.g. ExpandConnects + Dedup), but instead serves as a baseline for most cases when a bulk connect would work.Contributor Checklist
docs/src?Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Squash and merge
Release Notes
Emit FIRRTL bulk connects whenever possible when using a
MonoConnectorBiConnectReviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Please Merge?