Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.13.8 to plugin cross-compilation #2385

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

jackkoenig
Copy link
Contributor

Needed so that 3.5.1 [plugin] release will be available for Scala 2.13.8

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [NA] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Downstream users will now be able to use Scala 2.13.8 (compiler plugin must be published for every minor version)

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

The chisel3 plugin is now published for Scala 2.13.8.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.5.x milestone Feb 1, 2022
@jackkoenig jackkoenig added Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. release issue labels Feb 1, 2022
@mergify mergify bot merged commit 551854b into master Feb 2, 2022
@mergify mergify bot deleted the scala-2-13-8 branch February 2, 2022 00:30
mergify bot pushed a commit that referenced this pull request Feb 2, 2022
@mergify mergify bot added the Backported This PR has been backported label Feb 2, 2022
mergify bot added a commit that referenced this pull request Feb 2, 2022
(cherry picked from commit 551854b)

Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. release issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants