Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle elements performance regression #2396

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix bundle elements performance regression #2396

merged 2 commits into from
Feb 4, 2022

Commits on Feb 4, 2022

  1. Only call _elementsImpl once in Bundle.elements

    @jackkoenig
    jackkoenig committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    ec51eb6 View commit details
    Browse the repository at this point in the history

  2. Distinguish compiler plugin and reflective _elementsImpl 

    Bundle.elements now will only do post-processing if the user is using
plugin-generated _elementsImpl. This improves performance for the case
where the user does not opt-in to using the plugin to generate
_elementsImpl.
    @jackkoenig
    jackkoenig committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    f8e1454 View commit details
    Browse the repository at this point in the history