Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BlackBoxes in D/I #2438

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Support BlackBoxes in D/I #2438

merged 1 commit into from
Mar 9, 2022

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Mar 8, 2022 •
edited by mwachs5
Loading

Also delete an errant println in InstanceSpec.

Yeah I don't love the special casing. A cleaner solution is to improve DataView slightly (to support dynamic indexing of Vecs within a view), and then reimplement BlackBox to make it's val io Bundle be a view. This is a larger change though that requires touching a lot fo the codebase, and my goal was to fix this bug.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

This makes BlackBox work when used as an Instance

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Fix handling of BlackBoxes in Definition/Instance.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.5.x milestone Mar 8, 2022
@jackkoenig jackkoenig requested a review from azidar March 8, 2022 01:28
@jackkoenig
Support BlackBoxes in D/I
c0b9544 
Also delete an errant println in InstanceSpec
mwachs5
mwachs5 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving on the basis of the tests

@jackkoenig jackkoenig enabled auto-merge (squash) March 9, 2022 19:07
@jackkoenig jackkoenig merged commit 3462c54 into master Mar 9, 2022
@jackkoenig jackkoenig deleted the blackbox-in-di branch March 9, 2022 19:52
mergify bot pushed a commit that referenced this pull request Mar 9, 2022
@jackkoenig
Support BlackBoxes in D/I (#2438)
0f6b019 
Also delete an errant println in InstanceSpec

(cherry picked from commit 3462c54)
@mergify mergify bot mentioned this pull request Mar 9, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported label Mar 9, 2022
mergify bot added a commit that referenced this pull request Mar 9, 2022
@mergify @jackkoenig
Support BlackBoxes in D/I (#2438) (#2442)
4ee545d 
Also delete an errant println in InstanceSpec

(cherry picked from commit 3462c54)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request May 3, 2022
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

@azidar azidar Awaiting requested review from azidar

Assignees
No one assigned
Labels
Backported This PR has been backported
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @mwachs5