Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typos in doc comment #2490

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Fix small typos in doc comment #2490

merged 1 commit into from
Apr 18, 2022

Conversation

geekLucian
Copy link
Contributor

@geekLucian geekLucian commented Apr 18, 2022 •
edited by mwachs5
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

code cleanup (fix typos)

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mwachs5
mwachs5 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mwachs5 mwachs5 added this to the 3.4.x milestone Apr 18, 2022
@mwachs5 mwachs5 added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Apr 18, 2022
@mergify mergify bot merged commit 52165fe into chipsalliance:master Apr 18, 2022
mergify bot pushed a commit that referenced this pull request Apr 18, 2022
@geekLucian
Fix small typos in doc comment (#2490)
514e3b9 
(cherry picked from commit 52165fe)
@mergify mergify bot mentioned this pull request Apr 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Apr 18, 2022
@geekLucian
Fix small typos in doc comment (#2490)
1a45b05 
(cherry picked from commit 52165fe)
@mergify mergify bot mentioned this pull request Apr 18, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported label Apr 18, 2022
mergify bot added a commit that referenced this pull request Apr 18, 2022
@mergify @geekLucian
Fix small typos in doc comment (#2490) (#2491)
5dd5ce4 
(cherry picked from commit 52165fe)

Co-authored-by: Lucheng Zhang <79909456+geekLucian@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Apr 18, 2022
@mergify @geekLucian
Fix small typos in doc comment (#2490) (#2492)
17c9305 
(cherry picked from commit 52165fe)

Co-authored-by: Lucheng Zhang <79909456+geekLucian@users.noreply.github.com>
@sequencer sequencer mentioned this pull request May 3, 2022
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@geekLucian @CLAassistant @mwachs5