Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message for BlackBox without val io <: Record #2504

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix error message for BlackBox without val io <: Record #2504

merged 1 commit into from
Apr 25, 2022

Conversation

jackkoenig
Copy link
Contributor

Fixes #2451

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Fix bad error message for BlackBoxes without val io or with val io of the wrong type.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.5.x milestone Apr 25, 2022
@jackkoenig jackkoenig merged commit f9aee1f into master Apr 25, 2022
@jackkoenig jackkoenig deleted the fix-bb-io-error branch April 25, 2022 22:29
mergify bot pushed a commit that referenced this pull request Apr 25, 2022
@jackkoenig
Fix error message for BlackBox without val io <: Record (#2504)
44807a0 
(cherry picked from commit f9aee1f)
@mergify mergify bot mentioned this pull request Apr 25, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported label Apr 25, 2022
mergify bot added a commit that referenced this pull request Apr 25, 2022
@mergify @jackkoenig
Fix error message for BlackBox without val io <: Record (#2504) (#2505)
3e551ef 
(cherry picked from commit f9aee1f)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request May 3, 2022
Open
14 tasks
jackkoenig added a commit that referenced this pull request Feb 28, 2023
@jackkoenig
Use circuit name hashCode for circuit anno hashCode (#2504)
aea60aa 
It is unclear if having more than one circuit annotation even works. If
it does, it is implausible that they would have the same circuit name
since that would correspond to a namespace collision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.

BlackBox Crashes if io <: Record is Absent
3 participants
@jackkoenig @seldridge @mwachs5